Skip to content

fix(realtime): ignore object key order in search replacements - #7769

Merged
j15z merged 1 commit into
stagingfrom
codex/fix-search-replacement-comparison
Sep 12, 2026
Merged

fix(realtime): ignore object key order in search replacements#7769
j15z merged 1 commit into
stagingfrom
codex/fix-search-replacement-comparison

Conversation

@j15z

@j15z j15z commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Compare the current subblock value with the planned search replacement using structural equality. JSONB key ordering no longer causes a false conflict; changed values and reordered arrays still conflict.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

Three regression tests pass: equivalent nested objects with reordered keys, a changed tool parameter, and a reordered tool array. The full realtime suite also passes.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Not applicable.

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 12, 2026 8:29pm UTC

Request Review

@j15z
j15z force-pushed the codex/fix-search-replacement-comparison branch from 72bd253 to 5d57793 Compare September 12, 2026 20:13
@j15z
j15z force-pushed the codex/fix-workflow-import-errors branch from 9fbb134 to 455d3e2 Compare September 12, 2026 20:13
Base automatically changed from codex/fix-workflow-import-errors to staging September 12, 2026 20:24
@j15z
j15z force-pushed the codex/fix-search-replacement-comparison branch from 5d57793 to 26dc6fc Compare September 12, 2026 20:27
@j15z
j15z marked this pull request as ready for review September 12, 2026 22:54
@greptile-apps

greptile-apps Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with focused coverage for the corrected conflict-comparison behavior.

Summary

  • Replaces serialization-based comparison with structural equality.
  • Preserves conflicts for changed nested values and reordered arrays.
  • Adds focused regression coverage for successful and conflicting replacements.

Reviews (1) · Last reviewed commit: "fix(realtime): compare search replacemen..."

@j15z
j15z merged commit 1a7c827 into staging Sep 12, 2026
33 checks passed
@j15z
j15z deleted the codex/fix-search-replacement-comparison branch September 12, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant